Did duncan fit shakespeares role of a good king?

Yes. Shakespeare portrays Duncan in Macbeth as a virtuous king who is well-loved and respected by his people and loyal to his subjects. He is presented as a model of goodness and is held in high esteem.