No, Rocky and Columbia do not die in The Horror Picture Show. They survive the film entirely. The confusion stems from the movie's meta structure: Rocky and Columbia are the hosts of a "film-within-a-film," providing commentary on a series of slasher-movie clips. The characters they portray inside those clips—also named Rocky and Columbia—meet gruesome ends, but the hosts themselves remain alive and well throughout the framing narrative.
It's a clever narrative device that blurs the line between reality and fiction—perfect for a cult classic that loves to subvert horror tropes.