While he did occasionally play characters who were not entirely "good" (perhaps a bit mischievous or misguided), he typically played the role of the hero, upholding justice and fighting against the bad guys.
So, while he may have played some characters with shades of grey, Roy Rogers was essentially a "good guy" throughout his movie career.