Using cheats to force shininess in SoulSilver is not recommended—it undermines gameplay and risks save corruption.
Answer: No, the Shiny Cheat does not make Pokémon eggs shiny. The cheat alters encounter rates for wild Pokémon only; it doesn't affect breeding genetics. Eggs hatched from cheat-generated shinies retain normal shiny odds.
Legitimate shiny hunting methods:
Finding shinies legitimately is more rewarding.