Herobrine is a fictional community-created character from Minecraft. As such, he has no canonical favorite color—it's entirely up to individual interpretation.
Fans often imagine dark colors (black, gray) to match his eerie vibe, or bright colors for contrast. Ultimately, you decide!