Do neopet morphing potions wear off?

No, Neopet morphing potions do not wear off. Once a Neopet is morphed, they will remain in that form permanently.

There is no way to reverse a morphing potion in the game, so it is a very permanent decision.