No, Teddy Duncan (Bridgit Mendler) and Spencer (Shane Harper) never permanently broke up.
They remained a couple throughout all four seasons. While they faced typical conflicts—jealousy, long-distance during Spencer's college years, miscommunication—they always reconciled. The series finale and the crossover "Good Luck Jessie: NYC Christmas" confirm they're still together as Teddy heads to college.