"Good" depends on the yardstick. Technically: pleasant tone, reliable pitch, comfortable pop range, decent breath control. Artistically: modest power, limited agility, narrow genre footprint (teen pop). Commercially: undeniable—platinum singles, sold-out tours, a generation's soundtrack.
She's a competent, commercially successful vocalist who connects with her demographic. Whether that equals "good" is subjective. A critic might say "serviceable"; a fan says "my childhood." Both are valid.