Are music download sites still illegal even when you pay a lifetime membership fee?

No, music download sites are not illegal even when you pay a lifetime membership fee. In fact, many legitimate music download sites offer lifetime membership options that allow users to download an unlimited amount of music for a one-time fee. Some popular examples include Bandcamp, where artists can set their own prices, and sites that pay artists directly, such as Qobuz.